How to not sound passive aggressive in code reviews?
up vote
0
down vote
favorite
As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It invariably ends up sounding like "X does Y, not Z. It's not needed here." in response to something like "don't we need to call function X here?".
So how do you properly respond to general review comments like "I think this is missing here" or "I think this is not needed here"? And how do you correct a coworker's misunderstanding without sounding snappy?
I'm asking because a coworker said "I think this comment doesn't accurately describe the code because X actually does Y". I was going to respond with "X actually doesn't do Y. Z is the one that actually does Y". However, it just sounds slightly snarky. I for sure would be a little annoyed if someone responded to me like that.
colleagues code
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
0
down vote
favorite
As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It invariably ends up sounding like "X does Y, not Z. It's not needed here." in response to something like "don't we need to call function X here?".
So how do you properly respond to general review comments like "I think this is missing here" or "I think this is not needed here"? And how do you correct a coworker's misunderstanding without sounding snappy?
I'm asking because a coworker said "I think this comment doesn't accurately describe the code because X actually does Y". I was going to respond with "X actually doesn't do Y. Z is the one that actually does Y". However, it just sounds slightly snarky. I for sure would be a little annoyed if someone responded to me like that.
colleagues code
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
2 hours ago
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It invariably ends up sounding like "X does Y, not Z. It's not needed here." in response to something like "don't we need to call function X here?".
So how do you properly respond to general review comments like "I think this is missing here" or "I think this is not needed here"? And how do you correct a coworker's misunderstanding without sounding snappy?
I'm asking because a coworker said "I think this comment doesn't accurately describe the code because X actually does Y". I was going to respond with "X actually doesn't do Y. Z is the one that actually does Y". However, it just sounds slightly snarky. I for sure would be a little annoyed if someone responded to me like that.
colleagues code
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It invariably ends up sounding like "X does Y, not Z. It's not needed here." in response to something like "don't we need to call function X here?".
So how do you properly respond to general review comments like "I think this is missing here" or "I think this is not needed here"? And how do you correct a coworker's misunderstanding without sounding snappy?
I'm asking because a coworker said "I think this comment doesn't accurately describe the code because X actually does Y". I was going to respond with "X actually doesn't do Y. Z is the one that actually does Y". However, it just sounds slightly snarky. I for sure would be a little annoyed if someone responded to me like that.
colleagues code
colleagues code
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 2 hours ago
Jonathan Park
104
104
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
2 hours ago
add a comment |
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
2 hours ago
1
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
2 hours ago
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
2 hours ago
add a comment |
2 Answers
2
active
oldest
votes
up vote
-1
down vote
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
1 hour ago
So, how would one correct another in a respectful manner?
– Richard U
12 mins ago
@RichardU as I said, by keeping everything personal out of the conversation and sticking to facts.in OP's example he ought to know his code best.simply stating that he wrote it in a way that Z does Y is more explanation or expression of intent than admonition.
– DigitalBlade969
4 mins ago
add a comment |
up vote
-1
down vote
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to do so indirectly.
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
Acting unsure makes it sound like you don't understand your own code. There is nothing snarky about saying"I took care of Y in the Z function".
– Laconic Droid
34 mins ago
@LaconicDroid no, that way is just a bit jarring. Remember, these are your coworkers and you have to deal with them every day. It's best to let people save face when possible. Be nice, until it's time to not be nice.
– Richard U
30 mins ago
It's not about saving face (at least in non asian culture) nor about who is right or wrong! it's about what is correct and objective. personal feelings, emotions and booboos have no place in professional discourse.You don't go around insulting/belittling people and they better don't take facts personal.The workplace is not a toddlers playground! Besides, as Laconic Droid said, you don't want to appear incompetent either, especially if it concerns your own work / code.
– DigitalBlade969
26 mins ago
@DigitalBlade969 You are misrepresenting my point. If the OP wants to come across in a way that is not confrontational, the best way is to present an out, in order to allow his coworker to save face. You never want to put something in a way that will publicly embarrass someone. That is not producive. People are not robots and do not take facts on face value alone. If you don't take personalities into account, you are in for a very rough ride.
– Richard U
14 mins ago
add a comment |
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
-1
down vote
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
1 hour ago
So, how would one correct another in a respectful manner?
– Richard U
12 mins ago
@RichardU as I said, by keeping everything personal out of the conversation and sticking to facts.in OP's example he ought to know his code best.simply stating that he wrote it in a way that Z does Y is more explanation or expression of intent than admonition.
– DigitalBlade969
4 mins ago
add a comment |
up vote
-1
down vote
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
1 hour ago
So, how would one correct another in a respectful manner?
– Richard U
12 mins ago
@RichardU as I said, by keeping everything personal out of the conversation and sticking to facts.in OP's example he ought to know his code best.simply stating that he wrote it in a way that Z does Y is more explanation or expression of intent than admonition.
– DigitalBlade969
4 mins ago
add a comment |
up vote
-1
down vote
up vote
-1
down vote
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
edited 1 hour ago
jcmack
7,24211539
7,24211539
answered 2 hours ago
DigitalBlade969
3,2001315
3,2001315
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
1 hour ago
So, how would one correct another in a respectful manner?
– Richard U
12 mins ago
@RichardU as I said, by keeping everything personal out of the conversation and sticking to facts.in OP's example he ought to know his code best.simply stating that he wrote it in a way that Z does Y is more explanation or expression of intent than admonition.
– DigitalBlade969
4 mins ago
add a comment |
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
1 hour ago
So, how would one correct another in a respectful manner?
– Richard U
12 mins ago
@RichardU as I said, by keeping everything personal out of the conversation and sticking to facts.in OP's example he ought to know his code best.simply stating that he wrote it in a way that Z does Y is more explanation or expression of intent than admonition.
– DigitalBlade969
4 mins ago
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
1 hour ago
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
1 hour ago
So, how would one correct another in a respectful manner?
– Richard U
12 mins ago
So, how would one correct another in a respectful manner?
– Richard U
12 mins ago
@RichardU as I said, by keeping everything personal out of the conversation and sticking to facts.in OP's example he ought to know his code best.simply stating that he wrote it in a way that Z does Y is more explanation or expression of intent than admonition.
– DigitalBlade969
4 mins ago
@RichardU as I said, by keeping everything personal out of the conversation and sticking to facts.in OP's example he ought to know his code best.simply stating that he wrote it in a way that Z does Y is more explanation or expression of intent than admonition.
– DigitalBlade969
4 mins ago
add a comment |
up vote
-1
down vote
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to do so indirectly.
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
Acting unsure makes it sound like you don't understand your own code. There is nothing snarky about saying"I took care of Y in the Z function".
– Laconic Droid
34 mins ago
@LaconicDroid no, that way is just a bit jarring. Remember, these are your coworkers and you have to deal with them every day. It's best to let people save face when possible. Be nice, until it's time to not be nice.
– Richard U
30 mins ago
It's not about saving face (at least in non asian culture) nor about who is right or wrong! it's about what is correct and objective. personal feelings, emotions and booboos have no place in professional discourse.You don't go around insulting/belittling people and they better don't take facts personal.The workplace is not a toddlers playground! Besides, as Laconic Droid said, you don't want to appear incompetent either, especially if it concerns your own work / code.
– DigitalBlade969
26 mins ago
@DigitalBlade969 You are misrepresenting my point. If the OP wants to come across in a way that is not confrontational, the best way is to present an out, in order to allow his coworker to save face. You never want to put something in a way that will publicly embarrass someone. That is not producive. People are not robots and do not take facts on face value alone. If you don't take personalities into account, you are in for a very rough ride.
– Richard U
14 mins ago
add a comment |
up vote
-1
down vote
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to do so indirectly.
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
Acting unsure makes it sound like you don't understand your own code. There is nothing snarky about saying"I took care of Y in the Z function".
– Laconic Droid
34 mins ago
@LaconicDroid no, that way is just a bit jarring. Remember, these are your coworkers and you have to deal with them every day. It's best to let people save face when possible. Be nice, until it's time to not be nice.
– Richard U
30 mins ago
It's not about saving face (at least in non asian culture) nor about who is right or wrong! it's about what is correct and objective. personal feelings, emotions and booboos have no place in professional discourse.You don't go around insulting/belittling people and they better don't take facts personal.The workplace is not a toddlers playground! Besides, as Laconic Droid said, you don't want to appear incompetent either, especially if it concerns your own work / code.
– DigitalBlade969
26 mins ago
@DigitalBlade969 You are misrepresenting my point. If the OP wants to come across in a way that is not confrontational, the best way is to present an out, in order to allow his coworker to save face. You never want to put something in a way that will publicly embarrass someone. That is not producive. People are not robots and do not take facts on face value alone. If you don't take personalities into account, you are in for a very rough ride.
– Richard U
14 mins ago
add a comment |
up vote
-1
down vote
up vote
-1
down vote
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to do so indirectly.
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to do so indirectly.
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
edited 14 mins ago
answered 54 mins ago
Richard U
83.9k62217331
83.9k62217331
Acting unsure makes it sound like you don't understand your own code. There is nothing snarky about saying"I took care of Y in the Z function".
– Laconic Droid
34 mins ago
@LaconicDroid no, that way is just a bit jarring. Remember, these are your coworkers and you have to deal with them every day. It's best to let people save face when possible. Be nice, until it's time to not be nice.
– Richard U
30 mins ago
It's not about saving face (at least in non asian culture) nor about who is right or wrong! it's about what is correct and objective. personal feelings, emotions and booboos have no place in professional discourse.You don't go around insulting/belittling people and they better don't take facts personal.The workplace is not a toddlers playground! Besides, as Laconic Droid said, you don't want to appear incompetent either, especially if it concerns your own work / code.
– DigitalBlade969
26 mins ago
@DigitalBlade969 You are misrepresenting my point. If the OP wants to come across in a way that is not confrontational, the best way is to present an out, in order to allow his coworker to save face. You never want to put something in a way that will publicly embarrass someone. That is not producive. People are not robots and do not take facts on face value alone. If you don't take personalities into account, you are in for a very rough ride.
– Richard U
14 mins ago
add a comment |
Acting unsure makes it sound like you don't understand your own code. There is nothing snarky about saying"I took care of Y in the Z function".
– Laconic Droid
34 mins ago
@LaconicDroid no, that way is just a bit jarring. Remember, these are your coworkers and you have to deal with them every day. It's best to let people save face when possible. Be nice, until it's time to not be nice.
– Richard U
30 mins ago
It's not about saving face (at least in non asian culture) nor about who is right or wrong! it's about what is correct and objective. personal feelings, emotions and booboos have no place in professional discourse.You don't go around insulting/belittling people and they better don't take facts personal.The workplace is not a toddlers playground! Besides, as Laconic Droid said, you don't want to appear incompetent either, especially if it concerns your own work / code.
– DigitalBlade969
26 mins ago
@DigitalBlade969 You are misrepresenting my point. If the OP wants to come across in a way that is not confrontational, the best way is to present an out, in order to allow his coworker to save face. You never want to put something in a way that will publicly embarrass someone. That is not producive. People are not robots and do not take facts on face value alone. If you don't take personalities into account, you are in for a very rough ride.
– Richard U
14 mins ago
Acting unsure makes it sound like you don't understand your own code. There is nothing snarky about saying"I took care of Y in the Z function".
– Laconic Droid
34 mins ago
Acting unsure makes it sound like you don't understand your own code. There is nothing snarky about saying"I took care of Y in the Z function".
– Laconic Droid
34 mins ago
@LaconicDroid no, that way is just a bit jarring. Remember, these are your coworkers and you have to deal with them every day. It's best to let people save face when possible. Be nice, until it's time to not be nice.
– Richard U
30 mins ago
@LaconicDroid no, that way is just a bit jarring. Remember, these are your coworkers and you have to deal with them every day. It's best to let people save face when possible. Be nice, until it's time to not be nice.
– Richard U
30 mins ago
It's not about saving face (at least in non asian culture) nor about who is right or wrong! it's about what is correct and objective. personal feelings, emotions and booboos have no place in professional discourse.You don't go around insulting/belittling people and they better don't take facts personal.The workplace is not a toddlers playground! Besides, as Laconic Droid said, you don't want to appear incompetent either, especially if it concerns your own work / code.
– DigitalBlade969
26 mins ago
It's not about saving face (at least in non asian culture) nor about who is right or wrong! it's about what is correct and objective. personal feelings, emotions and booboos have no place in professional discourse.You don't go around insulting/belittling people and they better don't take facts personal.The workplace is not a toddlers playground! Besides, as Laconic Droid said, you don't want to appear incompetent either, especially if it concerns your own work / code.
– DigitalBlade969
26 mins ago
@DigitalBlade969 You are misrepresenting my point. If the OP wants to come across in a way that is not confrontational, the best way is to present an out, in order to allow his coworker to save face. You never want to put something in a way that will publicly embarrass someone. That is not producive. People are not robots and do not take facts on face value alone. If you don't take personalities into account, you are in for a very rough ride.
– Richard U
14 mins ago
@DigitalBlade969 You are misrepresenting my point. If the OP wants to come across in a way that is not confrontational, the best way is to present an out, in order to allow his coworker to save face. You never want to put something in a way that will publicly embarrass someone. That is not producive. People are not robots and do not take facts on face value alone. If you don't take personalities into account, you are in for a very rough ride.
– Richard U
14 mins ago
add a comment |
Jonathan Park is a new contributor. Be nice, and check out our Code of Conduct.
Jonathan Park is a new contributor. Be nice, and check out our Code of Conduct.
Jonathan Park is a new contributor. Be nice, and check out our Code of Conduct.
Jonathan Park is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to The Workplace Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f124438%2fhow-to-not-sound-passive-aggressive-in-code-reviews%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
2 hours ago